Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/cert-manager/cert-manager from 1.16.1 to 1.16.2 #6771

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2024

Bumps github.com/cert-manager/cert-manager from 1.16.1 to 1.16.2.

Release notes

Sourced from github.com/cert-manager/cert-manager's releases.

v1.16.2

cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters.

This patch release of cert-manager 1.16 makes several changes to how PEM input is validated, adding maximum sizes appropriate to the type of PEM data which is being parsed.

This is to prevent an unacceptable slow-down in parsing specially crafted PEM data. The issue was found by Google's OSS-Fuzz project.

The issue is low severity; to exploit the PEM issue would require privileged access which would likely allow Denial-of-Service through other methods.

Note also that since most PEM data parsed by cert-manager comes from ConfigMap or Secret resources which have a max size limit of approximately 1MB, it's difficult to force cert-manager to parse large amounts of PEM data.

Further information is available in GHSA-r4pg-vg54-wxx4

In addition, the version of Go used to build cert-manager 1.16 was updated along with the base images.

Changes by Kind

Bug or Regression

  • Set a maximum size for PEM inputs which cert-manager will accept to remove possibility of taking a long time to process an input (#7401, @​SgtCoDFish)

Other (Cleanup or Flake)

Commits
  • 33df0f2 Merge pull request #7431 from SgtCoDFish/release-1.16-bumps
  • 03f9832 [release-1.16] bump go + base images
  • 5001e8b Merge pull request #7401 from SgtCoDFish/release-1.16-pem-inputs
  • 3ba1f2c [release-1.16] bump base images
  • d99dddb security: remove calls to pem.Decode in non-test code
  • 481b67b security: Add functions to limit max PEM sizes allowable
  • 24f59c3 Merge pull request #7370 from SgtCoDFish/release-1.16-ipv6-dns
  • a9785d4 [release-1.16] add IPv6 example for recursive DNS arg
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) from 1.16.1 to 1.16.2.
- [Release notes](https://github.com/cert-manager/cert-manager/releases)
- [Changelog](https://github.com/cert-manager/cert-manager/blob/master/RELEASE.md)
- [Commits](cert-manager/cert-manager@v1.16.1...v1.16.2)

---
updated-dependencies:
- dependency-name: github.com/cert-manager/cert-manager
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner November 20, 2024 20:49
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 20, 2024
@dependabot dependabot bot requested review from skriss and sunjayBhatia and removed request for a team November 20, 2024 20:49
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and wilsonwu and removed request for a team November 20, 2024 20:49
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (fbf2d58) to head (90292f3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6771   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         133      133           
  Lines       20006    20006           
=======================================
  Hits        16212    16212           
  Misses       3500     3500           
  Partials      294      294           
---- 🚨 Try these New Features:

@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 21, 2024
@tsaarni
Copy link
Member

tsaarni commented Nov 21, 2024

The cert-manager vulnerability mentioned here does not impact users of Contour. Cert-manager is used for test code only.

@tsaarni tsaarni merged commit 4607ac2 into main Nov 21, 2024
31 of 34 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cert-manager/cert-manager-1.16.2 branch November 21, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant