Remove slack notification in CI workflows #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Associated slack workspace is now defunct and notifications were minimally useful at this point. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
tsaarni,
skriss,
a team,
rajatvig and
davinci26
and removed request for
a team
|
can also remove the associated slack webhook url secret |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6727 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 133 133
Lines 19996 19997 +1
=======================================
+ Hits 16200 16201 +1
Misses 3503 3503
Partials 293 293 |
Are you still planning to remove the associated environment variables from the YAML files in this PR or in separate PR? e.g. |
ah yes will remove in this one |
Signed-off-by: Sunjay Bhatia <[email protected]>
tsaarni
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated slack workspace is now defunct and notifications were minimally useful at this point.