Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused Makefile variables #6595

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

skriss
Copy link
Member

@skriss skriss commented Aug 1, 2024

Removes ENVOY_IMAGE, SRCDIRS, LOCAL_BOOTSTRAP_CONFIG and SECURE_LOCAL_BOOTSTRAP_CONFIG.

Removes ENVOY_IMAGE, SRCDIRS, LOCAL_BOOTSTRAP_CONFIG
and SECURE_LOCAL_BOOTSTRAP_CONFIG.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Aug 1, 2024
@skriss skriss requested a review from a team as a code owner August 1, 2024 14:14
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team August 1, 2024 14:14
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team August 1, 2024 14:22
Copy link
Member

@tsaarni tsaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (10f2b77) to head (9f6e6e7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6595   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         133      133           
  Lines       15942    15942           
=======================================
  Hits        13035    13035           
  Misses       2614     2614           
  Partials      293      293           

@skriss skriss merged commit bdee0a4 into projectcontour:main Aug 1, 2024
30 checks passed
@skriss skriss deleted the pr-rm-envoy-make-var branch August 1, 2024 14:59
geomacy pushed a commit to chaosbox/contour that referenced this pull request Aug 22, 2024
Removes ENVOY_IMAGE, SRCDIRS, LOCAL_BOOTSTRAP_CONFIG
and SECURE_LOCAL_BOOTSTRAP_CONFIG.

Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
SamMHD pushed a commit to SamMHD/contour that referenced this pull request Sep 8, 2024
Removes ENVOY_IMAGE, SRCDIRS, LOCAL_BOOTSTRAP_CONFIG
and SECURE_LOCAL_BOOTSTRAP_CONFIG.

Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Saman Mahdanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants