Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableCompression: Expose configuration to toggle Envoy GZIP compression on the responses #6546

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

disableCompression: Expose configuration to toggle Envoy GZIP compression on the responses #6546

wants to merge 35 commits into from
+1,120 −191

Commits on Jul 9, 2024

  1. build(deps): bump docker/setup-buildx-action from 3.3.0 to 3.4.0 (pro… 

    …jectcontour#6543)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@d70bba7...4fd8129)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: chaosbox <[email protected]>
    @dependabot
    dependabot[bot] authored and chaosbox committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b4d5b67 View commit details
    Browse the repository at this point in the history

  2. Adds "disableCompression" as a feature to turnon/off Envoy's GZIP res… 

    …ponse compression

Signed-off-by: chaosbox <[email protected]>
    chaosbox committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    081a47c View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge remote-tracking branch 'upstream/main' 

    # Conflicts:
#	.github/workflows/build_main.yaml
#	.github/workflows/build_tag.yaml
#	.github/workflows/prbuild.yaml
    Geoff Macartney committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    818ccf0 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. This fixes linter nag parameter 'conf' seems to be unused 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @tsaarni
    Geoff Macartney and tsaarni committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7ddb6f0 View commit details
    Browse the repository at this point in the history

  2. This fixes linter nag File is not gci-ed with ... 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @tsaarni
    Geoff Macartney and tsaarni committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8df07e2 View commit details
    Browse the repository at this point in the history

  3. This fixes linter nag File is not gci-ed with ... 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @tsaarni
    Geoff Macartney and tsaarni committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    100bf40 View commit details
    Browse the repository at this point in the history

  4. This fixes linter nag File is not gofumpt-ed with -extra 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @tsaarni
    Geoff Macartney and tsaarni committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    56e4ee7 View commit details
    Browse the repository at this point in the history

  5. This fixes linter nag File is not gofumpt-ed with -extra 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @tsaarni
    Geoff Macartney and tsaarni committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    548981e View commit details
    Browse the repository at this point in the history

  6. Fix table borders 

    This change is solely a formatting change and does not change any of the text of the table

Signed-off-by: Geoff Macartney <[email protected]>
    geomacy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    934ca48 View commit details
    Browse the repository at this point in the history

  7. Add disableCompression flag to configuration docs. 

    Signed-off-by: Geoff Macartney <[email protected]>
    geomacy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2efb693 View commit details
    Browse the repository at this point in the history

  8. add changelog file 

    Signed-off-by: Geoff Macartney <[email protected]>
    geomacy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b0cfe71 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Merge remote-tracking branch 'upstream/main' 

    Signed-off-by: Geoff Macartney <[email protected]>
    @geomacy
    geomacy committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    72e0e9c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge remote-tracking branch 'upstream/main'

    Geoff Macartney committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    73c4b67 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge remote-tracking branch 'upstream/main'

    Geoff Macartney committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    235acc3 View commit details
    Browse the repository at this point in the history

  2. rework as --compression flag with options gzip, brotli, zstd, disabled 

    Signed-off-by: Geoff Macartney <[email protected]>
    @geomacy
    geomacy authored and Geoff Macartney committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7e843b7 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from chaosbox/compression-flag 

    Rework as --compression flag.

Signed-off-by: Geoff Macartney <[email protected]>
    @geomacy
    geomacy authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    36dbadb View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. add validation to crd compression field 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f7b261b View commit details
    Browse the repository at this point in the history

  2. delete unnecessary output log 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    b68f0b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. define compression with a struct for API extensibility 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5dcdc33 View commit details
    Browse the repository at this point in the history

  2. lint fixes 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3d83394 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. test fix 

    Avoid NPE in parameters.Validate

also tidy flag handling in registerServe, don't set compression struct unless parameter is supplied.

Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cda9c76 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fix flag handling 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ff84c37 View commit details
    Browse the repository at this point in the history

  2. api lint 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5725a53 View commit details
    Browse the repository at this point in the history

  3. parameters_test 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    630541e View commit details
    Browse the repository at this point in the history

  4. update comment 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4610b80 View commit details
    Browse the repository at this point in the history

  5. fix assertion arg order and bump timeout 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    45ea946 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. add some servecontext tests 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    98225fc View commit details
    Browse the repository at this point in the history

  2. add some parameters tests 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    661b552 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Update internal/featuretests/v3/compression_test.go 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @geomacy @tsaarni
    2 people authored and Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    75f8b7b View commit details
    Browse the repository at this point in the history

  2. Update changelogs/unreleased/6546-chaosbox-small.md 

    Co-authored-by: Tero Saarni <[email protected]>
Signed-off-by: Geoff Macartney <[email protected]>
    @geomacy @tsaarni
    2 people authored and Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    351a820 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pr-6546-review-comments 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    89060c0 View commit details
    Browse the repository at this point in the history

  4. remove command flag 

    from review comment:

Let's remove the command line option and make configuration available only through config file and ContourConfiguration CRD.

The command line options currently are a bit of a mess, so we previously agreed to avoid introducing new options there unless absolutely necessary.

Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    95d38af View commit details
    Browse the repository at this point in the history

  5. treat empty string as valid CompressionAlgorithm 

    From review:

Would it be cleaner to treat an empty string as a valid value here, rather than completely bypassing validation in Parameters.Validate()? While algorithm is the only field currently, that might change.

Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    366f48d View commit details
    Browse the repository at this point in the history

  6. update configuration docs per new types 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1a6465f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. lint 

    Signed-off-by: Geoff Macartney <[email protected]>
    Geoff Macartney committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    43f6598 View commit details
    Browse the repository at this point in the history