Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote upstream TLS changelog entry from minor to major #6033

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Dec 20, 2023

After #5828 was merged (Thank You @KauzClay!) it occurred to me that we could promote the change from minor to major category, to call out the maximum TLS protocol version update. All information was there already, but I think it could be good to highlight it as a major change, since users might observe some differences with their upstream services after upgrade, when TLS handshake selects TLSv1.3. In worst case users could even have some minor problems due to the gaps in Envoy's retry handling, described in envoyproxy/envoy#9300.

@tsaarni tsaarni requested a review from a team as a code owner December 20, 2023 19:04
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team December 20, 2023 19:04
@sunjayBhatia sunjayBhatia requested review from a team and clayton-gonsalves and removed request for a team December 20, 2023 19:04
@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Dec 20, 2023
@tsaarni
Copy link
Member Author

tsaarni commented Dec 20, 2023

@KauzClay could you review this since I'm proposing change to your changelog entry? Thank you 😄

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a579ec3) 78.70% compared to head (c9ce1e9) 78.70%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6033   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         138      138           
  Lines       19717    19717           
=======================================
  Hits        15518    15518           
  Misses       3895     3895           
  Partials      304      304           

@KauzClay
Copy link
Contributor

@tsaarni cool, I see what you're saying about potential surprised when connections opt to 1.3.

Your changes make sense to me 👍

@tsaarni tsaarni merged commit 7dd40af into projectcontour:main Dec 20, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants