Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace deprecated function #6024

Closed
wants to merge 1 commit into from
Closed

chore: replace deprecated function #6024

wants to merge 1 commit into from

Conversation

yyzxw
Copy link

@yyzxw yyzxw commented Dec 18, 2023 •
edited
Loading

replace instr.FromInt to instr.FormInt32, FromInt has been deprecated

@yyzxw yyzxw requested a review from a team as a code owner December 18, 2023 03:36
@yyzxw yyzxw requested review from tsaarni and stevesloka and removed request for a team December 18, 2023 03:36
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and clayton-gonsalves and removed request for a team December 18, 2023 03:36
davinci26
davinci26 reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@davinci26 davinci26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Appreciate it!

LGTM modulo one small thing

I am ok with both the docs change and the replacement in a single PR but I would defer to the maintainers to make the final call.

If we decide to keep take the PR as is tho we should update the title and PR description such that it is clear what this PR does.

@davinci26 davinci26 added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Dec 18, 2023
@yyzxw
chore: replace deprecated function
57a51d5 
Signed-off-by: yyzxw <[email protected]>
Signed-off-by: xiaowu.zhu <[email protected]>
@yyzxw yyzxw force-pushed the chore/remove-deprecated-func branch from 68c8133 to 57a51d5 Compare December 26, 2023 07:05
sunjayBhatia
sunjayBhatia requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these comments from a previous iteration of this PR still apply to this one:

@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2024
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinci26 davinci26 davinci26 left review comments

@sunjayBhatia sunjayBhatia sunjayBhatia requested changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

@clayton-gonsalves clayton-gonsalves Awaiting requested review from clayton-gonsalves clayton-gonsalves was automatically assigned from projectcontour/contour-reviewers

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyzxw @sunjayBhatia @davinci26