-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes to Gateway API conformance on release tag #5894
Minor fixes to Gateway API conformance on release tag #5894
Conversation
sunjayBhatia
commented
Oct 24, 2023
•
edited
Loading
edited
- Don't build/load contour image to kind as we should be using the image we just pushed
- Fill in Gateway API version from our environment var
We should be using the image we just pushed Signed-off-by: Sunjay Bhatia <[email protected]>
noticed when looking at logs for https://github.com/projectcontour/contour/actions/runs/6632046855/job/18017005554 |
The build in CI on the 1.27.0 rc-1 tag worked and used the right contour version, but it did an extra step to build the local contour and load it into the kind cluster, this change just omits that |
I see |
yeah, that comes from the suite itself, though maybe we can put in the right version ourselves, I'll push a quick commit |
Signed-off-by: Sunjay Bhatia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5894 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 139 139
Lines 19614 19614
=======================================
Hits 15410 15410
Misses 3901 3901
Partials 303 303 |