Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to Gateway API conformance on release tag #5894

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Oct 24, 2023

  • Don't build/load contour image to kind as we should be using the image we just pushed
  • Fill in Gateway API version from our environment var

We should be using the image we just pushed

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Oct 24, 2023
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner October 24, 2023 20:37
@sunjayBhatia sunjayBhatia requested review from tsaarni, stevesloka and skriss and removed request for a team October 24, 2023 20:37
@sunjayBhatia
Copy link
Member Author

@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Oct 24, 2023

The build in CI on the 1.27.0 rc-1 tag worked and used the right contour version, but it did an extra step to build the local contour and load it into the kind cluster, this change just omits that

@skriss
Copy link
Member

skriss commented Oct 24, 2023

I see gatewayAPIVersion: TODO in the report, is that expected?

@sunjayBhatia
Copy link
Member Author

I see gatewayAPIVersion: TODO in the report, is that expected?

yeah, that comes from the suite itself, though maybe we can put in the right version ourselves, I'll push a quick commit

@sunjayBhatia sunjayBhatia changed the title Minor fix to Gateway API conformance on release tag Minor fixes to Gateway API conformance on release tag Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #5894 (41c5f34) into main (381c2c5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5894   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         139      139           
  Lines       19614    19614           
=======================================
  Hits        15410    15410           
  Misses       3901     3901           
  Partials      303      303           

@sunjayBhatia sunjayBhatia merged commit 6917d85 into projectcontour:main Oct 24, 2023
26 checks passed
@sunjayBhatia sunjayBhatia deleted the minor-fix-release-gw-api-conformance-report branch October 24, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants