Skip routability features

Signed-off-by: Sunjay Bhatia <[email protected]>
projectcontour · Aug 4, 2023 · aabcc8d · aabcc8d
1 parent 066ebb1
commit aabcc8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/test/conformance/gatewayapi/gateway_conformance_test.go b/test/conformance/gatewayapi/gateway_conformance_test.go
@@ -67,6 +67,10 @@ func TestGatewayConformance(t *testing.T) {
 		},
 		ExemptFeatures: sets.New(
 			suite.SupportMesh,
+			suite.SupportGatewayClassRoutability,
+			suite.SupportGatewayPublicRoutability,
+			suite.SupportGatewayPrivateRoutability,
+			suite.SupportGatewayClusterRoutability,
 		),
 	})
 	cSuite.Setup(t)

diff --git a/test/scripts/run-gateway-conformance.sh b/test/scripts/run-gateway-conformance.sh
@@ -58,9 +58,9 @@ else
   git clone https://github.com/kubernetes-sigs/gateway-api
   cd gateway-api
   git checkout "${GATEWAY_API_VERSION}"
-  # TODO: Keep the list of skipped features in sync with
+  # Keep the list of skipped features in sync with
   # test/conformance/gatewayapi/gateway_conformance_test.go.
-  # Can implement with the -skip flag available with go 1.20
-  # or if Gateway API supports skipping tests via custom flag.
-  go test -timeout=40m ./conformance -gateway-class=contour -all-features -exempt-features=Mesh -skip-tests=HTTPRouteRedirectPortAndScheme
+  go test -timeout=40m ./conformance -gateway-class=contour -all-features \
+    -exempt-features=Mesh,SupportGatewayClassRoutability,SupportGatewayPublicRoutability,SupportGatewayPrivateRoutability,SupportGatewayClusterRoutability \
+    -skip-tests=HTTPRouteRedirectPortAndScheme
 fi