Skip to content

Commit

Permalink
remove disabled ingress-conformance run from CI (#6032)
Browse files Browse the repository at this point in the history
Upstream Ingress conformance is flaky/poorly maintained and
unlikely to reach a state where it can reliably be run in CI.

Signed-off-by: Steve Kriss <[email protected]>
  • Loading branch information
skriss authored Dec 20, 2023
1 parent 111b7f9 commit a579ec3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/prbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -241,18 +241,6 @@ jobs:
steps: ${{ toJson(steps) }}
channel: '#contour-ci-notifications'
if: ${{ failure() && github.ref == 'refs/heads/main' }}
# TODO: re-enable once Ingress v1 support is complete
# ingress-conformance:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - name: add deps to path
# run: |
# ./hack/actions/install-kubernetes-toolchain.sh $GITHUB_WORKSPACE/bin
# echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
# - name: ingress conformance tests
# run: |
# make check-ingress-conformance
test-linux:
needs:
- lint
Expand Down
8 changes: 0 additions & 8 deletions hack/actions/install-kubernetes-toolchain.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ set -o pipefail

readonly KUBECTL_VERS="v1.29.0"
readonly KIND_VERS="v0.20.0"
readonly SONOBUOY_VERS="0.19.0"

readonly PROGNAME=$(basename $0)
readonly CURL=${CURL:-curl}
Expand Down Expand Up @@ -50,10 +49,3 @@ download \
"${DESTDIR}/kubectl"

chmod +x "${DESTDIR}/kubectl"

download \
"https://github.com/vmware-tanzu/sonobuoy/releases/download/v${SONOBUOY_VERS}/sonobuoy_${SONOBUOY_VERS}_linux_amd64.tar.gz" \
"${DESTDIR}/sonobuoy.tgz"

tar -C "${DESTDIR}" -xf "${DESTDIR}/sonobuoy.tgz" sonobuoy
rm "${DESTDIR}/sonobuoy.tgz"

0 comments on commit a579ec3

Please sign in to comment.