feat: Allow additional SANS for web certificate #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
heytrav
force-pushed
the
fix/webhook-cert-sans
branch
from
757ee28 to
8603f89
Compare
heytrav
changed the title
heytrav
force-pushed
the
fix/webhook-cert-sans
branch
3 times, most recently
from
51f71ee to
14a93b0
Compare
prometherion
requested changes
Dec 23, 2024
|
CI is very picky, please, check the failed actions: if you're struggling let me know and I'll edit your PR! |
heytrav
force-pushed
the
fix/webhook-cert-sans
branch
from
f2c2bd2 to
627b2c7
Compare
I think squashing the extra commit might help. |
|
|
heytrav
force-pushed
the
fix/webhook-cert-sans
branch
from
627b2c7 to
552b1a1
Compare
This makes it possible to include extra variants of the service-name
that aren't captured by the {{ include "capsule.fullname" }} macro
Signed-off-by: Travis Holton <[email protected]>
Update charts/capsule/README.md
Co-authored-by: Dario Tranchitella <[email protected]>
heytrav
force-pushed
the
fix/webhook-cert-sans
branch
from
552b1a1 to
c4164b7
Compare
prometherion
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to include extra variants of the service-name that aren't captured by the {{ include "capsule.fullname" }} macro