feat: add flag --workers #1013
Open
feat: add flag --workers #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
There was a problem hiding this comment.
This is interesting, although it could lead to potential issues since multiple reconciliations at the same time could generate errors due to updating of the same resource at the same time.
What I did with Kamaji was rely on a file-lock system, even tho this could be a bit more complicated: clastix/kamaji#255
It would be perfect if we could rely on it, honestly, the license is compatible with Apache2.
WDYT @oliverbaehler?
|
@prometherion Sure thing, i will implement a locking mechanism |
Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
force-pushed
the
feat/workers
branch
from
42a81bd to
9b4e980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the workers flag you can configure the concurrent reconciles on relevant controllers. This is interesting for large cluster infrastructures