feat(form): Implements feature for projectcaluma/caluma#1699 #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Being only superficially familiar with the project, I am not entirely sure whether the failing test needs to be amended (https://github.com/projectcaluma/caluma/actions/runs/5614946237/job/15230363555?pr=2035#step:5:2681) or the |
winged
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Awesome work! Just some small nitpicks and cleanups to do.
Also, as we're using conventional commits, you should reword the commit message to use feat(form) ... instead of fix, as it's a new feature, not a bugfix.
Other than that, great work and thanks for the contribution :-)
maria-pw
force-pushed
the
fix/handle-failed-or-omitted-file-uploads
branch
from
ffecb78
to
e421f59
Compare
maria-pw
changed the title
maria-pw
force-pushed
the
fix/handle-failed-or-omitted-file-uploads
branch
from
e421f59
to
b31ae11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.