fix blacklight version check #3265
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnoneill
force-pushed
the
bug-patch-11-13
branch
from
4356329
to
799b031
Compare
|
@dnoneill how do I duplicate the problem this PR is fixing? |
|
@corylown In main, be logged in. Go to one of the item pages. Reload the page. The "edit" button should disappear because it is no longer using the correct component. |
|
I can't duplicate this problem on main |
|
I am the only one who could recreate this. Closing due to my computer's haunting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blacklight::VERSION returns "8.6.1"
For some reason I could not figure out blacklight_config.show.document_component == Blacklight::DocumentComponent wouldn't work. The classes wouldn't line up correctly.