Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have csv export template use slug for custom fields to match import #3205

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dnoneill
Copy link
Contributor

closes #2994

@dnoneill dnoneill force-pushed the 2994-custom-fields-csv-import branch from c66518a to b207588 Compare October 17, 2024 22:35
@taylor-steve
Copy link
Contributor

Do you know if this PR will re-introduce the bug that this previous PR was addressing?

https://github.com/projectblacklight/spotlight/pull/2506/files

Just curious because this PR seems to essentially be a revert of that.

@corylown
Copy link
Contributor

corylown commented Oct 18, 2024

I think this does re-introduce the bug fixed here: #2506
(hinting at a missing test?)

Maybe the fix is to instead export the custom field slugs instead of the field name when the template is generated: ?

It's possible this was missed when we switched to prefer the slug over the full field name for sidecar data here: https://github.com/projectblacklight/spotlight/pull/2201/files

@dnoneill
Copy link
Contributor Author

I was wondering about this. I am wondering if we want to support both. I could see instances where the solr field is preferred as well.

@dnoneill dnoneill force-pushed the 2994-custom-fields-csv-import branch from b207588 to ef742d7 Compare October 18, 2024 14:11
@dnoneill
Copy link
Contributor Author

Decision was made to update the template download

@dnoneill dnoneill force-pushed the 2994-custom-fields-csv-import branch from ef742d7 to 35dbcb3 Compare October 18, 2024 15:28
@dnoneill dnoneill changed the title have csv import based on field_name for custom fields not label have csv export template use slug for custom fields to match import Oct 18, 2024
@corylown corylown merged commit 18a1f55 into main Oct 18, 2024
6 checks passed
@corylown corylown deleted the 2994-custom-fields-csv-import branch October 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV loader does not convey data for exhibit-specific fields into Solr
3 participants