Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a precompiled favicon #299

Closed
wants to merge 1 commit into from
Closed

Conversation

garrett
Copy link
Contributor

@garrett garrett commented Apr 11, 2016

This commit should eliminate the need for compile-time favicon
generation... and imagemagick, which then pulled in X11 (in Fedora, *)

(The PR should fix #296)

this should eliminate the need for compile-time favicon
generation... and imagemagick, which then pulled in X11 (in Fedora, *)

(this fixes projectatomic#296)
@jberkus
Copy link
Contributor

jberkus commented Apr 11, 2016

Thanks! Testing now.

@jberkus
Copy link
Contributor

jberkus commented Apr 11, 2016

@garrett fails for me:

identical build/blog/tag/fedora/page=2/index.html
identical build/blog/tag/atomic/page=2/index.html
/usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/creator.rb:61:in ``': No such file or directory - convert (Errn
o::ENOENT)
from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/creator.rb:61:infetch_image_magick_version' from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/creator.rb:20:in initialize'
from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/generator.rb:41:in`new'

    from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/generator.rb:41:in `block in start'
    from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/generator.rb:38:in `each'
    from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/generator.rb:38:in `start'
    from /usr/local/share/gems/gems/favicon_maker-1.3/lib/favicon_maker/generator.rb:8:in `generate'
    from /usr/local/share/gems/gems/middleman-favicon-maker-3.7/lib/middleman-favicon-maker/extension.rb:19:in `after_buil

d'

@jberkus
Copy link
Contributor

jberkus commented Apr 19, 2016

@garrett?

@jberkus
Copy link
Contributor

jberkus commented Jul 8, 2016

Given lack of response on this, closing the PR. Please reopen if you can fix the bugs. Thanks.

@jberkus jberkus closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy without ImageMagick?
2 participants