Enable the native-certs feature flag on ureq.
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this might help with an edge case bug where some users were reporting log messages regarding being unable to get a local issuer certificate. *Previously:* without this flag - `ureq` would effectively just use an embedded-at-compile-time certificate set (Mozilla's). *Now:* with this flag, `ureq` will check the OS native cert store at client creation time, which means that if the lib or Dolphin build goes long(ish) periods without a release, there should be no risk of the cert store being out of whack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might help with an edge case bug where some users were reporting log messages regarding being unable to get a local issuer certificate.
Previously: without this flag -
ureqwould effectively just use an embedded-at-compile-time certificate set (Mozilla's).Now: with this flag,
ureqwill check the OS native cert store at client creation time, which means that if the lib or Dolphin build goes long(ish) periods without a release, there should be no risk of the cert store being out of whack.