fix: no longer short-circuit the news feed fetch #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a Medium news feed fetch failed
(for example, if it is blocked by a firewall), the entire
fetchNewsFeedData() function would short-circuit and throw a
{ number, string } error, preventing the GitHub releases-based news
from being displayed.
This commit fixes it by returning a fallback news
item in case a Medium news fetch fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract:
Previously, if a Medium news feed fetch failed (for example, if it is blocked by a firewall), the entire fetchNewsFeedData() function would short-circuit and throw a { number, string } error, preventing the GitHub releases-based news from being displayed.
This pull request changes this behaviour to instead return a fallback news post to notify the user of a failed Medium news fetch.
Considerations:
feedFetchAttempt?.status !== 200be used in thefetchMediumNews()function?Testing done:
The
fetchMediumNews()function works fine both on failure and on success, not failing/short-circuiting the rest offetchNewsFeedData()function.