Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing play twice while Slippi is in "Launch Dolphin" mode launches Melee directly #370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sticks-stuff
Copy link

A simple QoL change that makes it easier for people to get directly into Melee if they so choose

Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is a good idea in theory but in practice there are more things that need ironing out.

  1. We need to make sure Dolphin can still submit the game report when killed by the launcher
  2. Ideally we can just launch Melee directly in the existing Dolphin instance, without quitting Dolphin and re-opening it again.

CC: @NikhilNarayana

src/dolphin/manager.ts Outdated Show resolved Hide resolved

if (this.netplayDolphinInstance) {
if (!launchMeleeOnPlay) {
this.netplayDolphinInstance.kill();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.netplayDolphinInstance.kill();
this.netplayDolphinInstance.kill();

This sounds good in theory, but I worry that people could kill their dolphin process A) unintentionally (e.g. they're already in a game or in a training mode or something and we kill it), or B) intentionally by skirting around the game reporting logic in Dolphin (this is already an existing issue).

@sticks-stuff
Copy link
Author

Ideally we can just launch Melee directly in the existing Dolphin instance, without quitting Dolphin and re-opening it again.

This would be ideal however it seems beyond my skill level to do memory management stuff like that. External Melee Camera does have a way of calling native Dolphin functions (https://github.com/sadkellz/External-Melee-Camera/blob/main/External-Melee-Camera/emc_functions.py#L134) so maybe thats something to look into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants