Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [PR] Handle netplay Dolphin update via URI #340

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JLaferri
Copy link
Member

The idea behind this is that when Dolphin is not up to date, it shows an update button. when someone presses that update button, we'd like to update their Dolphin instead of requiring them to restart the launcher.

Currently testing this from the command line and it does seem to update the Dolphin version but it doesn't show the "Updating" UI, would probably like to add that.

@JLaferri
Copy link
Member Author

image

Another potential thing to consider is that if someone updates without having the Launcher installed they will see this. Afaik there's no great way to check if the launcher exists. Perhaps we could install another app that can be launched from the command line?

The backup option if they don't have the Launcher installed or if the URI fails (I don't know how to detect this), would be to send the person here: https://slippi.gg/downloads?update=true

I remember this having problems... don't remember atm
@zDEFz
Copy link

zDEFz commented Aug 11, 2023

The idea behind this is that when Dolphin is not up to date, it shows an update button. when someone presses that update button, we'd like to update their Dolphin instead of requiring them to restart the launcher.

Currently testing this from the command line and it does seem to update the Dolphin version but it doesn't show the "Updating" UI, would probably like to add that.

Proposal: Checksum part of the Launcher and if it differs, then invoke a function that downloads silently the newer files / cleans up, and quits SlippiLauncher / Ishiiruuka and then updates it, then starts it, if the new checksum matches. If the user wants to play with an outdated version, they'll have to update.

Back when I was doing bytecode based patches, I only had one file to update, and it was stupid simple: https://github.com/zDEFz/c2-patch/blob/main/EXTERNAL/updater.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants