Add get_router_diagnostics
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns the router counter diagnostics as a namedtuple.
This live test reads the routing table info *twice* from (1, 1) and in doing so ensures that the second reading's local P2P count increases. (Don't panic: the test accounts for the possibility of the counter wrapping around!)
|
Thank you very much for adding that one! I've just added a live test simply out of sheer paranoia since we've been bitten by it in the past ;). That said, "shockingly", it does in fact seem to work! When you're happy with my additional test, merge at will! I'd say this definitely covers part one of #45. I should ask Genting about his histogram-related discoveries at some point... |
|
That's a very slick live test, thank you. I'd really like a script that displays a heat map of dropped multicast packets, but that's for another day. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns the router counter diagnostics as a namedtuple.