feat: AuthProvider 구현 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| setLocalStorageItem(USER_KEY, { | ||
| nickname: responseMember.nickname, | ||
| location: responseMember.location, | ||
| }); | ||
| await memberFoodKeywordApi.saveMemberFoodKeywordAxios(foodKeywords); |
There was a problem hiding this comment.
혹시 tanstack query로 안한 이유가 있을까요?
There was a problem hiding this comment.
어떤 부분은 react query로 변경해보면 좋을까요?
제가 아직 익숙하지 않아서 그런것 같네요
There was a problem hiding this comment.
useMutation을 사용하시면 create/update/delete 메서드 들에 대해서 조금 더 쉽게 처리가 가능할 거 같아요 :) 아무래도 저희가 이번에는 tanstack query를 최대한 사용하는게 목표라서 한번 사용해보시는것도 좋은 방법일 거 같습니다 :)
There was a problem hiding this comment.
이를 사용해서 onSuccess 같은 곳에서 query key invalidation을 통해 stale한 데이터에 대해서도 invalidate를 하기도 수월할 거 같습니다 :)
Muscardinus94
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 주제
작업 내용(어떤 부분을 리뷰어가 집중해서 봐야할까요?)
체크리스트(PR 올리기 전 아래의 내용을 확인해주세요.)
리뷰 규칙