Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite ovmf vars if they exist #29

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Do not overwrite ovmf vars if they exist #29

merged 1 commit into from
Oct 23, 2023

Conversation

hallyn
Copy link
Contributor

@hallyn hallyn commented Oct 17, 2023

The VM may have made ovmf vars changes. We do not want to clobber those.

@hallyn
Do not overwrite ovmf vars if they exist
7f3d542 
The VM may have made ovmf vars changes.  We do not want to clobber
those.

Signed-off-by: Serge Hallyn <[email protected]>
@hallyn hallyn requested a review from raharper October 17, 2023 15:48
raharper
raharper approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ultimately want to expose some way to let user/API control this. If this is a better default for the use-case then let's change it now.

@hallyn hallyn merged commit d6156ca into project-machine:main Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raharper raharper raharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallyn @raharper