Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session close refactoring #467

Merged
merged 24 commits into from
Oct 31, 2023
Merged

Session close refactoring #467

merged 24 commits into from
Oct 31, 2023

Conversation

Apollon77
Copy link
Collaborator

This PR is refactoring session handling especially in the area of "closing sessions" to assure that:

  • Sessions send close messsages when they should and not when not
  • Sessions are closed direvctly or delayed
  • When closing a session delayed then it is closed after the exchange really ended (and not after the pure interaction till now - because exchanges might have a close timer to make sure all retries happened)
  • Adding Session closiure handling also for Controller 8that one was ignoring that till now)
  • Adjust chip-testing to execute log tests correctly and allow to trigger log tests by commit message

@Apollon77
Sessions need to remember how they needs to be closed
a48a2df 
To make the code flow easier it makes sense to store in the session instance if a session should be closed delayed or if a session close message should be sent out
@Apollon77
Adjust session close callback to re,ove parameter now stored in session
a70bbe2
@Apollon77
Adjust session close callback to re,ove parameter now stored in session
bfeb627
@Apollon77
Move actual close session to ExchangeManager
1c2b66d 
Session closes can be triggered "synchronously" or "delayed when current running intercations were finished". The latter was not be correct because it is not the interaction that matters but the exchange that gets finished after the interaction is finished. Additionally the logic only implemented for MatterDevice nd not for Controller. So we move closing session logic to exchangemanager.
@Apollon77
Adjust Session closure when removing a fabric
c79e69b 
The session used to remove the fabric is closed delayed, all others immediately.
@Apollon77
Allow controller to also receive Secure channel StatusReports
37589ae 
Needed that the Controller receives StatusReports for Session closures from devices
@Apollon77
Adjust session creation in Controller
d9959b7
@Apollon77
Add subscription closure even with throwing error to cleanup
ea2fd0e
@Apollon77
Split removeSession and removeResumptionRecord
8e3e9a0
@Apollon77
Do not use sessions already marked as closed as Pase session
28425ec
@Apollon77
removing all sessions can be doewith and without session close
9c0fcf2
@Apollon77
use new method from last commit
97f13da
@Apollon77
use new method from last commit
e19c0e1
@Apollon77
adjust fabric tests
f2526ac
@Apollon77
adjust Integration tests
5939e7d
@Apollon77
Finalize
75e8b1a
@Apollon77
[execute-chiptests-long] Allow to trigger Log chiptests too and fix s…
79ac3ac 
…cheduled run
@Apollon77 Apollon77 requested a review from lauckhart October 31, 2023 15:26
lauckhart
lauckhart approved these changes Oct 31, 2023
View reviewed changes
packages/matter.js/src/protocol/ExchangeManager.ts Outdated Show resolved Hide resolved
packages/matter.js/src/session/SecureSession.ts Outdated Show resolved Hide resolved
@Apollon77 Apollon77 merged commit 4ef32c9 into project-chip:main Oct 31, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauckhart lauckhart lauckhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apollon77 @lauckhart