Full scope search for named references #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
Apollon77,
turon,
vves and
woody-apple
Apollon77
approved these changes
Dec 31, 2024
Adds support for default values that are named references. For any property with a default value that is a named reference, a managed struct will return the referenced value until set explicitly. Adds logic that searches for properties by name in any owner of a managed value. This allows conformance expression constraints and default values to reference values by name so long as they are visible in any object in the ownership hierarchy. Previously we only supported referencing values that were siblings. I believe this is the last feature we need to support 100% of the data model semantics used in the Matter specifications (as of Matter 1.4).
lauckhart
force-pushed
the
scoped-name-resolution
branch
from
f8eb3f9 to
e1b0528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for default values that are named references. For any property with a default value that is a named reference, a managed struct will return the referenced value until set explicitly.
Adds logic that searches for properties by name in any owner of a managed value. This allows conformance expressions, constraints and default values to reference values by name so long as they are visible in any object in the ownership hierarchy. Previously we only supported referencing values that were siblings.
I believe this is the last feature we need to support 100% of the data model semantics used in the Matter specifications (as of Matter 1.4).