Logging Optimization and Restructuring #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Keylike" means that the key is suppressed and the value is rendered like a key.
This gets an object of values and the keys of all "truthy" values will be added as space delimited list. "keylikeFlags" directly renders it with a keylike presentation.
This commits adds a "logContext" to the Exchange#send code flow and fills it with values. Ideally Messagetypes and such are determined automatically from the protocolId and opCode
This commit streamlines logging in the two Messengers and simplifies it.
Allows to disable MRP logic wehn sending exchange data - this is used when pushing out subscription data on shutdown where we do not want to have a full MRP retransmission cycle, so we just push the message without waiting for ack and just wait for Success for a shorter time to not block shutdown. In this case oushing submission infos is "by chance" anyway, so that's ok
pullapprove
bot
requested review from
lauckhart,
turon,
vves and
woody-apple
lauckhart
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logging and combines some loglines into one. This mainly means that we have more information in the exchange message logs.
It also adds one Shutdown optimization already because of code-overlappings: It allows to disable Exchange MRP logic which means that the message is sent but the ack is not awaited and returned directly. With this we can use a shorter timeout when waiting for the answer in case of node shutdowns where last subscription information are pushed before going offline.
Rest see commit comments