Skip to content

Commit

Permalink
take out macos tests till upstream fixes come in (#487)
Browse files Browse the repository at this point in the history
* Add node-gyp as dep and adjust actions

* take out macos build until new versions of noble and bleno are released that pin node-gyp

* make test reliable again
  • Loading branch information
Apollon77 authored Nov 6, 2023
1 parent 9b2270b commit fa95c59
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
7 changes: 0 additions & 7 deletions .github/actions/prepare-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ runs:
with:
node-version: ${{ inputs.node-version }}

- name: patch node gyp on windows to support Visual Studio 2019
if: ${{ inputs.os == 'windows-latest' || inputs.os == 'windows-2019' }}
shell: powershell
run: |
npm install --global node-gyp@latest
npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"}
- name: Install dependencies (Non-Windows)
if: ${{ inputs.os != 'windows-latest' && inputs.os != 'windows-2019' }}
shell: bash
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build-test.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
src:
- "package.json"
- "packages/**/package.json"
- ".github/workflows/build-test.js.yml"
- name: Prepare testing environment
uses: ./.github/actions/prepare-env
- run: npm run format-verify
Expand All @@ -38,7 +39,8 @@ jobs:
strategy:
matrix:
node-version: [ 16.x, 18.x, 20.x ]
os: [ macos-latest, windows-2019 ]
# os: [ macos-latest, windows-2019 ]
os: [ windows-2019 ]
steps:
- uses: actions/checkout@v4
if: ${{ needs.check-and-lint.outputs.package-changes == 'true' }}
Expand Down
2 changes: 1 addition & 1 deletion packages/matter-node.js/test/IntegrationTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,7 @@ describe("Integration Test", () => {

assert.equal(commissioningChangedCallsServer.length, 2);
assert.ok(sessionChangedCallsServer.length >= 7);
assert.equal(sessionChangedCallsServer[7].fabricIndex, FabricIndex(2));
assert.equal(sessionChangedCallsServer[sessionChangedCallsServer.length - 1].fabricIndex, FabricIndex(2));
const sessionInfo = commissioningServer.getActiveSessionInformation();
assert.equal(sessionInfo.length, 2);
assert.ok(sessionInfo[1].fabric);
Expand Down

0 comments on commit fa95c59

Please sign in to comment.