Makes sure to always announce all fabrics (#413)

* Makes sure to always announce all fabrics ... else they would be expired which is wrong behaviour * Update IntegrationTest.ts * formatting
project-chip · Oct 19, 2023 · cd4ed84 · cd4ed84
1 parent e78c95d
commit cd4ed84
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 35 deletions.
diff --git a/packages/matter-node.js/test/IntegrationTest.ts b/packages/matter-node.js/test/IntegrationTest.ts
@@ -1505,29 +1505,15 @@ describe("Integration Test", () => {
     });
 
     after(async () => {
-        const promise = mdnsBroadcaster.expireAllAnnouncements(matterPort);
-
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.advance(150);
-        await MockTime.advance(150);
-        await MockTime.yield();
-
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.yield();
-        await MockTime.advance(150);
-        await MockTime.advance(150);
-        await MockTime.yield();
-
-        await promise;
+        // For closing all down we need to use the real Time implementation
+        const mockTimeInstance = Time.get();
+        Time.get = singleton(() => new TimeNode());
 
         await matterServer.close();
         await matterClient.close();
         await fakeControllerStorage.close();
         await fakeServerStorage.close();
+
+        Time.get = () => mockTimeInstance;
     });
 });
diff --git a/packages/matter.js/src/MatterDevice.ts b/packages/matter.js/src/MatterDevice.ts
@@ -148,29 +148,23 @@ export class MatterDevice {
         }
         const fabrics = this.fabricManager.getFabrics();
         if (fabrics.length) {
-            const fabricsToAnnounce: Fabric[] = [];
+            let fabricsToAnnounce = 0;
             for (const fabric of fabrics) {
                 const session = this.sessionManager.getSessionForNode(fabric, fabric.rootNodeId);
                 if (
-                    session !== undefined &&
-                    session.isSecure() &&
-                    (session as SecureSession<this>).numberOfActiveSubscriptions > 0
+                    session === undefined ||
+                    !session.isSecure() ||
+                    (session as SecureSession<this>).numberOfActiveSubscriptions === 0
                 ) {
-                    // We have a session, no need to re-announce
-                    logger.debug(
-                        "Skipping announce for fabric",
-                        fabric.fabricId,
-                        "because we have a session with active subscriptions",
-                        session.getId(),
-                    );
-                    continue;
+                    fabricsToAnnounce++;
+                    logger.debug("Announcing", Logger.dict({ fabric: fabric.fabricId }));
                 }
-                logger.debug("Announcing", Logger.dict({ fabric: fabric.fabricId }));
-                fabricsToAnnounce.push(fabric);
             }
             for (const broadcaster of this.broadcasters) {
-                await broadcaster.setFabrics(fabricsToAnnounce);
-                await broadcaster.announce();
+                await broadcaster.setFabrics(fabrics);
+                if (fabricsToAnnounce > 0) {
+                    await broadcaster.announce();
+                }
             }
         } else {
             // No fabric paired yet, so announce as "ready for commissioning"