icd management: make the feature map and operating mode managed by AAI #37062
+110
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37062: Size comparison from 5bd63d5 to 4282d48 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Jan 14, 2025
|
PR #37062: Size comparison from 5bd63d5 to d422523 Full report (3 builds for cc32xx, stm32)
|
bzbarsky-apple
approved these changes
Jan 15, 2025
|
PR #37062: Size comparison from 26a867c to d24a2cd Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 15, 2025
| @@ -16,6 +16,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| #include "app-common/zap-generated/cluster-enums.h" | |||
There was a problem hiding this comment.
use <> for includes to be consistent. Move them after the framework include
andy31415
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OperatingMode attribute and FeatureMap attribute of ICDManagement cluster should be managed by AAI instead of ember as the ICDConfigurationData maintains values for the two attributes
Testing