Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test that exercises receiving an invalid WriteRequest message. #37053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a test that exercises receiving an invalid WriteRequest message. #37053

wants to merge 1 commit into from
+70 −0

Conversation

bzbarsky-apple
Copy link
Contributor

Testing

This is a test.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

PR #37053: Size comparison from 5bd63d5 to 8b10aad

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 5bd63d5 8b10aad change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1355350 1355350 0 0.0
RAM 103952 103952 0 0.0
bl702 lighting-app bl702+eth FLASH 726034 726034 0 0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 912904 912904 0 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1173762 1173762 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1082790 1082790 0 0.0
RAM 16604 16604 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840176 840176 0 0.0
RAM 123552 123552 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825692 825692 0 0.0
RAM 125440 125440 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772620 772620 0 0.0
RAM 113916 113916 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756816 756816 0 0.0
RAM 114116 114116 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540041 540041 0 0.0
RAM 205304 205304 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574209 574209 0 0.0
RAM 205448 205448 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681569 681569 0 0.0
RAM 78596 78596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701413 701413 0 0.0
RAM 81236 81236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701413 701413 0 0.0
RAM 81236 81236 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658357 658357 0 0.0
RAM 73664 73664 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618153 618153 0 0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637789 637789 0 0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637789 637789 0 0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637601 637601 0 0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657317 657317 0 0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657317 657317 0 0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614213 614213 0 0.0
RAM 68684 68684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634065 634065 0 0.0
RAM 71316 71316 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634065 634065 0 0.0
RAM 71316 71316 0 0.0
efr32 lock-app BRD4187C FLASH 932468 932468 0 0.0
RAM 160068 160068 0 0.0
BRD4338a FLASH 749232 749224 -8 -0.0
RAM 233196 233196 0 0.0
window-app BRD4187C FLASH 1026864 1026856 -8 -0.0
RAM 128172 128172 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541904 1541904 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1548458 1548458 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2723229 2723229 0 0.0
RAM 133160 133160 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5996466 5996466 0 0.0
RAM 526072 526072 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5341652 5341652 0 0.0
RAM 243072 243072 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4696806 4696806 0 0.0
RAM 221824 221824 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12867152 12867152 0 0.0
RAM 587002 587002 0 0.0
chip-tool-ipv6only arm64 unknown 21536 21536 0 0.0
FLASH 10989440 10989440 0 0.0
RAM 638048 638048 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11274263 11274263 0 0.0
RAM 587346 587346 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4521756 4521756 0 0.0
RAM 208928 208928 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5622981 5622981 0 0.0
RAM 477880 477880 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5631329 5631329 0 0.0
RAM 232072 232072 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4744568 4744568 0 0.0
RAM 208072 208072 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4372108 4372108 0 0.0
RAM 201744 201744 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4510120 4510120 0 0.0
RAM 206312 206312 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3023197 3023197 0 0.0
RAM 160792 160792 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4110296 4110296 0 0.0
RAM 246368 246368 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5966741 5966741 0 0.0
RAM 601312 601312 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11102349 11102349 0 0.0
RAM 700496 700496 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917804 917804 0 0.0
RAM 143172 143172 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890868 890868 0 0.0
RAM 141359 141359 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 851932 0 0.0
RAM 142084 142084 0 0.0
nxp contact k32w0+release FLASH 585968 585968 0 0.0
RAM 70952 70952 0 0.0
mcxw71+release FLASH 601488 601488 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612588 612588 0 0.0
RAM 70344 70344 0 0.0
k32w1+release FLASH 687152 687152 0 0.0
RAM 48760 48760 0 0.0
lock mcxw71+release FLASH 763464 763464 0 0.0
RAM 70796 70796 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1652124 1652124 0 0.0
RAM 211632 211632 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1557884 1557884 0 0.0
RAM 208448 208448 0 0.0
light cy8ckit_062s2_43012 FLASH 1472492 1472492 0 0.0
RAM 200416 200416 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470276 1470276 0 0.0
RAM 224768 224768 0 0.0
qpg lighting-app qpg6105+debug FLASH 664144 664144 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 622004 622004 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484976 0 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683552 683552 0 0.0
RAM 91088 91088 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623810 623810 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772652 772652 0 0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777256 777256 0 0.0
RAM 99652 99652 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711250 711250 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628264 628264 0 0.0
RAM 142020 142020 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814266 814266 0 0.0
RAM 99564 99564 0 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1767272 1767272 0 0.0
RAM 93708 93708 0 0.0
chip-tool-ubsan arm unknown 10904 10904 0 0.0
FLASH 17949774 17949774 0 0.0
RAM 7842672 7842672 0 0.0

arkq
arkq approved these changes Jan 14, 2025
View reviewed changes
src/app/tests/TestWriteInteraction.cpp
EXPECT_TRUE(delegate.mLastStatusParsedSuccessfully);
EXPECT_EQ(delegate.mLastStatus, Protocols::InteractionModel::Status::InvalidAction);

engine->Shutdown();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Maybe some kind of followup (for all test cases) should be here to move that part to test SetUp/TearDown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

Assignees
No one assigned
Labels
app review - pending tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @arkq