feat: Add terms-and-conditions sample app for CI testing #36950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new sample application that demonstrates and tests the terms and conditions feature. This app will be integrated into the CI pipeline to prevent regressions and ensure the feature continues to work as expected. The sample app serves as both a reference implementation and an automated test case for the terms and conditions functionality. ```bash ./scripts/build/build_examples.py --target linux-x64-terms-and-conditions build ```
github-actions
bot
added
documentation
|
PR #36950: Size comparison from 2249628 to 5987aed Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #36950: Size comparison from 2249628 to c9b78ab Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/terms-and-conditions-app/terms-and-conditions-common/terms-and-conditions-app.matter
Outdated
Show resolved
Hide resolved
examples/terms-and-conditions-app/terms-and-conditions-common/terms-and-conditions-app.matter
Outdated
Show resolved
Hide resolved
- Enable switch cluster for basic app control testing - Enable network commissioning cluster for in-app commission testing - Disable provisional clusters as they are not required - Disable other non-required clusters to streamline testing setup This change focuses the cluster configuration on essential components needed for basic app control and commissioning testing scenarios.
|
PR #36950: Size comparison from 2249628 to e7c4a38 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/terms-and-conditions-app/terms-and-conditions-common/terms-and-conditions-app.matter
Outdated
Show resolved
Hide resolved
Remove unused attributes from the Switch cluster to comply with the "On/Off Light" device type specification as defined in the Matter device library v1.4. This change removes several server-side attributes including ServerList, ClientList, PartsList, and various internal lists that are not required for the basic On/Off Light functionality.
|
PR #36950: Size comparison from 8a0fc4d to 0d5a9b5 Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Add the mandatory Descriptor cluster to endpoint 1 and enable attribute reporting for the device. Changes include: - Add Descriptor cluster with all required attributes (deviceTypeList, serverList, etc.) - Enable reportable flag for multiple attributes with min/max reporting intervals - Configure all Descriptor cluster attributes as external callbacks This change ensures compliance with the Matter specification for the On/Off Light device type.
|
PR #36950: Size comparison from 8a0fc4d to 3cbffc4 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 14, 2025
chrisdecenzo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new sample application that demonstrates and tests the terms and conditions feature. This app will be integrated into the CI pipeline to prevent regressions and ensure the feature continues to work as expected.
The sample app serves as both a reference implementation and an automated test case for the terms and conditions functionality.
Testing
Used the chip-tool to commission chip-terms-and-conditions-app. Confirmed that the commissioning succeeds when terms are sent and fails when terms are not sent.