Fix PostAttributeChangeCallback value ctypes typing #36928
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
|
sasdf
force-pushed
the
post_attr_cb_buf
branch
4 times, most recently
from
185e1bb to
dc9ccac
Compare
sasdf
force-pushed
the
post_attr_cb_buf
branch
from
dc9ccac to
989b36b
Compare
|
PR #36928: Size comparison from af336ec to 989b36b Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sasdf
force-pushed
the
post_attr_cb_buf
branch
from
989b36b to
526b2d3
Compare
|
PR #36928: Size comparison from 017e8b5 to 526b2d3 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
As documented in the TODO, the callback requires the caller to pass a NULL-terminated C-string, but it’s actually a length-buffer pair. The python lighting example receives values with incorrect length due to this issue. This PR fixes the FFI interface by wrapping the callback function, and converts the length-buffer pair to a proper python bytes value.
sasdf
force-pushed
the
post_attr_cb_buf
branch
from
526b2d3 to
f55f76e
Compare
|
PR #36928: Size comparison from 2249628 to f55f76e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect PostAttributeChangeCallback's value argument ctypes typing, which is documented in the TODO.
The callback requires the caller to pass a NULL-terminated C-string, but it’s actually a length-buffer pair. The python lighting example receives values with incorrect length due to this issue.
With this PR, the
PostAttributeChangeCallbackdecorator will wrap the callback function, and converts the length-buffer pair to a proper python bytes value.To keep it backward-compatible, the length argument will still be passed to the callback, although it becomes redundant.