-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nullptr check for String TLV data with zero length #36921
Open
BoB13-Matter
wants to merge
2
commits into
project-chip:master
Choose a base branch
from
BoB13-Matter:add-tlv-string-nullptr-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add nullptr check for String TLV data with zero length #36921
BoB13-Matter
wants to merge
2
commits into
project-chip:master
from
BoB13-Matter:add-tlv-string-nullptr-check
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #36921: Size comparison from c1afc02 to f0f9e2c Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
BoB13-Matter
force-pushed
the
add-tlv-string-nullptr-check
branch
from
December 20, 2024 09:02
f0f9e2c
to
57d3b03
Compare
PR #36921: Size comparison from c1afc02 to 57d3b03 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 20, 2024
PR #36921: Size comparison from c1afc02 to f5f8835 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetDataPtr
to return a nullptrtlvData
pointer variable and passed as an argument towriter.Put()
writer.Put()
is executed,memmove
is called in BufferWriter.cpp:35, and thebuf
argument holds anullptr
Reproduce
nullptr
being returned.Changes
If
buf
is nullptr,memmove
is not executed in BufferWriter.cpp:35