Fix running async functions without event loop during testing #36859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36859: Size comparison from d162e3a to c308ab0 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Dec 16, 2024
|
PR #36859: Size comparison from d162e3a to 59f57f9 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36859: Size comparison from aac3e3f to 2098793 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Python testing uses
moblywhich is not async-oriented. To "fix" that the "asyncio.run" decorator is used for async functions. However, this provides async event loop only for the time of the test function execution, not for the entire mobly runtime lifetime. This fireback on us when the CHIP stack returns some future object after wrapped async test function returns:Changes
Run mobly in the
asyncio.runwhich provides event loop during whole mobly runtime. However, this requires to run another async event loop from the non-async mobly function... To fix that, the previous "asyncio.run" decorator was modified, so that it runs the event loop in a new thread and blocks the top-level event loop until the "nested" event loop terminates - the wrapped function returns.Testing
Tested locally that there are no exceptions like before. CI will verify for potential breaks.