Ability to create out-of-tree MEI clusters #36818
Draft
+177,243
−604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #36818: Size comparison from 75ab4c9 to 3158e54 Full report (3 builds for cc32xx, stm32)
|
There was a problem hiding this comment.
"mei" just means "identifier", in Matter... This is trying to show an example of a vendor-prefixed cluster, right? Should probably be named accordingly.
There was a problem hiding this comment.
This is named similar to https://github.com/project-chip/connectedhomeip/blob/master/src/app/clusters/sample-mei-server/sample-mei-server.cpp which is currently in the tree.
There was a problem hiding this comment.
Understood, and that one is not named well and should probably be renamed....
There was a problem hiding this comment.
@bzbarsky-apple I am in the process of updating the complete tree for SampleMei. Is there a way to ignore the 'Check controller-clusters.matter backwards compatibility' check so that the CI jobs are not getting cancelled? Since this is a sample cluster, not a standard matter cluster, this is not a problem for backwards compatibility.
bauerschwan
reviewed
Dec 17, 2024
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster. This commits: * adds an example for an external MEI cluster * adds an mei-template.json that creates app-common out-of-tree * adds build system modifications so that app-common which includes the external MEI cluster is being used when EXTERNAL_APP_COMMON is given to chip_configure_data_model().
markus-becker-tridonic-com
force-pushed
the
sample-external-mei
branch
from
3158e54 to
6923bb8
Compare
github-actions
bot
added
the
documentation
manufacturer-specific-app READMEs
…AfReadAttribute lint step
|
PR #36818: Size comparison from e7082e2 to 7787e44 Full report (7 builds for cc13x4_26x4, cc32xx, stm32)
|
|
PR #36818: Size comparison from e7082e2 to b7b76d7 Full report (5 builds for cc32xx, stm32, tizen)
|
|
PR #36818: Size comparison from e7082e2 to b830097 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36818: Size comparison from e7082e2 to b0d8bb0 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matter allows for MEI clusters. Currently, there is an example of such a cluster in the tree: sample-mei-server. If device vendors want to create their own MEI cluster, it currently needs to be included in tree, because app-common would not include information of the out-of-tree MEI cluster.
This commits:
Testing