-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Implement DiagnosticLog #36591
Merged
yunhanw-google
merged 12 commits into
project-chip:master
from
joonhaengHeo:implement_android_diag_log
Dec 4, 2024
Merged
[Android] Implement DiagnosticLog #36591
yunhanw-google
merged 12 commits into
project-chip:master
from
joonhaengHeo:implement_android_diag_log
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonhaengHeo
force-pushed
the
implement_android_diag_log
branch
from
November 29, 2024 07:18
7f85d1d
to
d82e05e
Compare
PR #36591: Size comparison from b3e074c to 8a4894e Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #36591: Size comparison from b3e074c to 8d219df Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
force-pushed
the
implement_android_diag_log
branch
from
December 1, 2024 22:04
245cb03
to
8653d56
Compare
PR #36591: Size comparison from e402b96 to 8653d56 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/controller/java/src/chip/devicecontroller/DownloadLogCallback.java
Outdated
Show resolved
Hide resolved
yunhanw-google
approved these changes
Dec 2, 2024
yunhanw-google
approved these changes
Dec 2, 2024
...les/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt
Outdated
Show resolved
Hide resolved
...les/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt
Show resolved
Hide resolved
joonhaengHeo
force-pushed
the
implement_android_diag_log
branch
from
December 2, 2024 23:20
ae8a824
to
a5a28c1
Compare
joonhaengHeo
force-pushed
the
implement_android_diag_log
branch
from
December 2, 2024 23:26
a5a28c1
to
6bfcb10
Compare
PR #36591: Size comparison from a3a443a to 6bfcb10 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36591: Size comparison from a3a443a to 0b7a814 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
Outdated
Show resolved
Hide resolved
PR #36591: Size comparison from e0fc29a to be99a5f Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
PR #36591: Size comparison from e0fc29a to 9a01003 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
Dec 4, 2024
This was referenced Dec 5, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Implement Android DiagnosticLog * Update from comment * Restyled * Update DiagnosticLog UX (Download complete / failed) * Fix timeout issue * Fix java-controller build error * modify from comment * Add javadoc, test cases * kotlin code style * Fix from comment * Fix build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31647
Implement DiagnosticLog in Android ChipTool and Java controller.
Test:
Add new DiagnosticLog test inside JavaMatterController in CI
Using real aqara device for testing.