Clean up and unify ColorTemp command handlers of the color control #36377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
This was referenced Nov 5, 2024
|
PR #36377: Size comparison from 2a7106f to ab8e54d Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Nov 6, 2024
|
PR #36377: Size comparison from 2a7106f to a456bba Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
force-pushed
the
Unify_CC_Temp_command_handling
branch
from
86d5c6e to
c30f687
Compare
|
PR #36377: Size comparison from 2af51b0 to c30f687 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rcasallas-silabs
approved these changes
Nov 7, 2024
andy31415
approved these changes
Nov 7, 2024
|
PR #36377: Size comparison from 2af51b0 to 88ceef9 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#36377) * Clean up and unify ColorTemp command handlers of the color control * Fix tien build by updating api call * Replace auto by type * Replace local variable usage by commandData. * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the 2nd of a few that splits #36202 into smaller chunks for ease of review and to ensure that no regression slips through
sibling PR #36376 #36378