-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] add API to get public key without leaks (with fixes) #36340
Conversation
PR #36340: Size comparison from b0cc28a to d5bfe8d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
…onal method calls
it's a test; this is the best we can do with an optional protocol method
remove comment - not this method's job to worry about other implementation's potential side-effects
Co-authored-by: Boris Zbarsky <[email protected]>
PR #36340: Size comparison from f3a9fe9 to 47e264a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
check compatibility in CI before going back and removing
PR #36340: Size comparison from f3a9fe9 to 8dbbcaa Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36340: Size comparison from f3a9fe9 to d328eaf Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36340: Size comparison from 50ad31c to fbbd06a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36340: Size comparison from 62a4a97 to fdbd53c Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/darwin-framework-tool/commands/common/CHIPToolKeypair.mm
Outdated
Show resolved
Hide resolved
PR #36340: Size comparison from 62a4a97 to a761b1c Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36340: Size comparison from 62a4a97 to 4b278ea Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #36340: Size comparison from 62a4a97 to f1c3920 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…t-chip#36340) * Initial checkin * Fixing review feedback * Adding braces * Restyled by clang-format * Fixing build * Restyled by clang-format * Fixing annotations * Update src/darwin/Framework/CHIP/MTRKeypair.h Co-authored-by: Boris Zbarsky <[email protected]> * separate statements involving _mPublicKey to make compiler happy * use `CFAutorelease` on CoreFoundation typed public key copies * fix indent * implement `copyPublicKey` for `MTRTestKeys`; add TODO note about optional method calls * remove comment it's a test; this is the best we can do with an optional protocol method * consistent formatting for `copyPublicKey` calls * reformat `copyPublicKey` in `MTRTestKeys` remove comment - not this method's job to worry about other implementation's potential side-effects * Update src/darwin/Framework/CHIP/MTRKeypair.h Co-authored-by: Boris Zbarsky <[email protected]> * re-add `publicKey` in `CHIPToolKeypair` check compatibility in CI before going back and removing * use `copyPublicKey` in more places * dedupe public key cache population for CHIPToolKeypair * Restyled by clang-format * try manually releasing pubkey in test * leakfix: MTRP256KeypairBridge * leakfix: `MTRCertificateTests.testGenerateCSR` * remove unnecessary plain `publicKey` implementation * temporarily do the inelegant patch on CFAutorelease * fix another remaining `publicKey` instance * Restyled by clang-format * fix `publicKey` deprecation, marking for future release --------- Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
reverted because mergify landed it with failing checks...?
CFAutorelease
on CoreFoundation typed public key copiescopyPublicKey
forMTRTestKeys
; add TODO note about optional method callscopyPublicKey
callscopyPublicKey
inMTRTestKeys