Improve formatting of Error Logs related to CHIP_ERROR in GoogleTest #36265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #36265: Size comparison from 0b981e7 to 654741a Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/GoogleTestErrorFormatting
branch
from
654741a to
4e78187
Compare
|
PR #36265: Size comparison from 2142870 to 4e78187 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/GoogleTestErrorFormatting
branch
from
4e78187 to
f69755c
Compare
|
PR #36265: Size comparison from d38d56b to 83b60fd Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/GoogleTestErrorFormatting
branch
from
dda6106 to
d8ab669
Compare
Alami-Amine
force-pushed
the
AA/GoogleTestErrorFormatting
branch
from
d8ab669 to
cd889c2
Compare
Alami-Amine
changed the title
|
PR #36265: Size comparison from d38d56b to d7173e2 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 31, 2024
jmartinez-silabs
approved these changes
Oct 31, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#36265) * Improve formatting of errors related to CHIP_ERROR in GoogleTest * Improve formatting of errors related to CHIP_ERROR in GoogleTest * Add a buildconfig header for GoogleTest * Activating CHIP_ERROR log formatter for pw_fuzzer fuzztests * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pw_fuzzer FuzzTestsAND can be optionally used for building unit tests.Fix
we teach GoogleTest to format the error log using
PrintTofunction and give us the Error Code and line where the error was triggered.This was previously done for Unit Tests built using
pw_unit_test:lightbackend, by using Pigweed's adapterToString<CHIP_ERROR>.a Buildconfig header was also added to make sure
PrintTois not compiled when GoogleTest is not used.Example of Failure Log with PrintTo:
Notes:
build_examples.py#Undo googletest in.gnand replace it with a build variant #36268