[ICD] Set MaximumCheckInBackOff to external and fix define guards for unit test members #36223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 6 files. Overall, the semantic diff is 67% smaller than the GitHub diff.
|
jmartinez-silabs
approved these changes
Oct 23, 2024
|
PR #36223: Size comparison from 197f698 to 444c60b Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
mkardous-silabs
force-pushed
the
fix/icd_server
branch
from
444c60b to
a6183dc
Compare
|
PR #36223: Size comparison from 197f698 to a6183dc Full report (9 builds for cc13x4_26x4, cc32xx, stm32, tizen)
|
yunhanw-google
approved these changes
Oct 24, 2024
|
PR #36223: Size comparison from 197f698 to 2eefa5f Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 24, 2024
… unit test members (project-chip#36223) * Fix ICD manager and attributes * Generated files * zap regen
gmarcosb
reviewed
Nov 14, 2024
| @@ -290,7 +290,8 @@ | |||
| "ActiveModeThreshold", | |||
| "RegisteredClients", | |||
| "ICDCounter", | |||
| "ClientsSupportedPerFabric" | |||
| "ClientsSupportedPerFabric", | |||
| "MaximumCheckInBackOff" | |||
There was a problem hiding this comment.
MaximumCheckInBackOff is tagged as apiMaturity="provisional" - should it be here?
There was a problem hiding this comment.
Where is this set? I'm not familiar with the apiMaturity tag
There was a problem hiding this comment.
There was a problem hiding this comment.
MaximumCheckInBackOff is tagged as apiMaturity="provisional" - should it be here?
@gmarcosb apiMaturity has absolutely nothing to do with whether things are listed in the JSON metadata.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
… unit test members (project-chip#36223) * Fix ICD manager and attributes * Generated files * zap regen
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jan 16, 2025
…fine guards for unit test members (project-chip#36223) (project-chip#36231) * Fix ICD manager and attributes * Generated files * zap regen (cherry picked from commit fd2d000) Signed-off-by: Adrian Gielniewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR addresses two issues in the ICD server code :
idefwhen the define was always set to 0 or 1. Updated the guard to correctly check the define valueOnly the first comment as functionnal changes. The second is just the generation.
CI and generation to validate the changes