Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-ALOGIN-12.2 - updates step 2 as per verification steps #36206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

TC-ALOGIN-12.2 - updates step 2 as per verification steps #36206

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d22c7c
updates step 2
raul-marquez-csa Oct 22, 2024
de18434
Merge branch 'master' into TC-ALOGIN-12.2-issue-366
raul-marquez-csa Oct 23, 2024
4262f40
Merge branch 'master' into TC-ALOGIN-12.2-issue-366
raul-marquez-csa Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/tests/suites/certification/Test_TC_ALOGIN_12_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ tests:
verification: |
Product maker needs to provide instructions for how to trigger the command on the DUT. For comparison, the DUT behavior for this test step can be simulated using chip-tool (when DUT is a commissioner) or tv-casting-app (when DUT is a commissionee):

./chip-tool accountlogin login 11111 34567890 1 4 --timedInteractionTimeoutMs 1000
./chip-tv-casting-app accountlogin login 11111 34567890 1 4 --timedInteractionTimeoutMs 1000
./chip-tool accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000
./chip-tv-casting-app accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000
Comment on lines +111 to +112
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple Oct 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct value here would depend on the relevant DUT, no? Why are we changin this to "20202021" specifically? It would be better to make it clear that the value here is a placeholder that would need to get replaced with the right value at test time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajashreekalmane, can you address this comment?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the Verification Sheet to address your comment regarding the placeholder value "20202021." The value is now explicitly marked as a placeholder, with a note indicating that it should be replaced with the appropriate value based on the relevant DUT at test time.

Here are the clarified instructions:
./chip-tool accountlogin login <TempAccountIdentifier> <SetupPIN> <destination-id> <endpoint-id-ignored-for-group-commands> [optional flags]
Argument Descriptions
TempAccountIdentifier: Replace it with the appropriate identifier for your DUT.
SetupPIN: Replace it with the PIN specific to your DUT.
destination-id: Replace it with the actual node ID of the DUT.
Example Command:
./chip-tool accountlogin login 11111 20202021 1 4 --timedInteractionTimeoutMs 1000
Updated Verification document for your reference : https://docs.google.com/spreadsheets/d/13zltSz50GRs_kidvobceEuIT8kAAHSK64ANyWcc3xQI/edit?usp=sharing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so the PR should be updated accordingly, right?


On TH (tv-app), Verify the login command is received successfully.

Expand Down
Loading