Add an API on MTRDevice to wait for attributes to reach certain values. #36205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36205: Size comparison from e36bde7 to 2d750d1 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
MTRDevice-value-expectation
branch
from
2d750d1 to
37d549d
Compare
|
PR #36205: Size comparison from b3223b6 to 37d549d Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ksperling-apple
previously approved these changes
Oct 30, 2024
bzbarsky-apple
commented
Oct 31, 2024
bzbarsky-apple
force-pushed
the
MTRDevice-value-expectation
branch
from
37d549d to
cd8e3a9
Compare
bzbarsky-apple
dismissed
ksperling-apple’s stale review
Various changes happened since the review
|
PR #36205: Size comparison from 62a4a97 to cd8e3a9 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36205: Size comparison from 62a4a97 to 3b360e5 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Nov 5, 2024
woody-apple
reviewed
Nov 5, 2024
ksperling-apple
approved these changes
Nov 6, 2024
|
Fast-tracking platform-specific fix with platform owner review. |
|
PR #36205: Size comparison from 62a4a97 to 1bd0403 Increases above 0.2%:
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
MTRDevice-value-expectation
branch
from
1bd0403 to
19f2ca5
Compare
|
PR #36205: Size comparison from 2af51b0 to 19f2ca5 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…s. (project-chip#36205) * Add an API on MTRDevice to wait for attributes to reach certain values. * Address review comments. * Address review comments. * Implement cancellation of attribute waiters. * Addressing more review comments. * Address review comments. * Fix build failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.