-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherry-Pick] Update WiseConnect to v3.3.3 (#36086) #36196
Merged
andy31415
merged 2 commits into
project-chip:v1.4-branch
from
arun-silabs:cherry-pick/wifi_sdk_3.3.3
Oct 23, 2024
Merged
[Cherry-Pick] Update WiseConnect to v3.3.3 (#36086) #36196
andy31415
merged 2 commits into
project-chip:v1.4-branch
from
arun-silabs:cherry-pick/wifi_sdk_3.3.3
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update wifi sdk to v3.3.3 * Updated matter_support pointer * Updated docker image WiseConnect v3.3.3 * Reverting the docker changes * Updated comments in DockerFile * Removed unused source file * Updated workflow to pick-up latest docker image * Updated docker version in the build files * Added changes to resolve build errors for brd2605a * Corrected variable name in gn file * Removed TO-DO comment * Replaced SI917_DEVKIT macro to SL_MATTER_RGB_LED_ENABLED * Resolved review comments * Updated WiseMcuSpam.cpp as per the latest defines * Update third_party/silabs/silabs_board.gni * Added sl_enable_rgb_led in inside if-else of soc board condition --------- Co-authored-by: bhmanda <[email protected]> Co-authored-by: Mathieu Kardous <[email protected]> Co-authored-by: bhmanda-silabs <[email protected]>
Review changes with SemanticDiff. Analyzed 2 of 12 files.
|
mkardous-silabs
added
the
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
label
Oct 22, 2024
mkardous-silabs
approved these changes
Oct 22, 2024
PR #36196: Size comparison from 8304c7a to 47d3b7c Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Oct 22, 2024
PR #36196: Size comparison from f2e5de7 to 73d4c2e Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 23, 2024
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jan 16, 2025
) (project-chip#36196) * Update wifi sdk to v3.3.3 * Updated matter_support pointer * Updated docker image WiseConnect v3.3.3 * Reverting the docker changes * Updated comments in DockerFile * Removed unused source file * Updated workflow to pick-up latest docker image * Updated docker version in the build files * Added changes to resolve build errors for brd2605a * Corrected variable name in gn file * Removed TO-DO comment * Replaced SI917_DEVKIT macro to SL_MATTER_RGB_LED_ENABLED * Resolved review comments * Updated WiseMcuSpam.cpp as per the latest defines * Update third_party/silabs/silabs_board.gni * Added sl_enable_rgb_led in inside if-else of soc board condition --------- Co-authored-by: bhmanda <[email protected]> Co-authored-by: Mathieu Kardous <[email protected]> Co-authored-by: bhmanda-silabs <[email protected]> (cherry picked from commit 9020be3) Signed-off-by: Adrian Gielniewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
examples
github
integrations
platform
silabs
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cherry-pick PR from CSA master to update WiseConnect to v3.3.3.