Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call DeviceReachableChanged when subscription fails #36175

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Call DeviceReachableChanged when subscription fails #36175

merged 2 commits into from
Oct 22, 2024

Conversation

tehampson
Copy link
Contributor

Whenever there is an issue subscribing to device that is bridged we updated the reachability in fabric-bridge BRBINFO cluster but calling DeviceReachableChanged

Makes more progress on #35333

Tests:

  • CI
  • Running local example terminated server fabric-admin was connected to. After subscription timed out, confirmed reach-ability attribute updated on fabric-bridge BRBINFO cluster.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

PR #36175: Size comparison from db7c54a to 4a305ff

Increases above 0.2%:

platform target config section db7c54a 4a305ff change % change
nxp lock mcxw71+release FLASH 705552 746712 41160 5.8
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section db7c54a 4a305ff change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350008 1350008 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647788 647788 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825274 825274 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1054200 1054200 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 975048 975048 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829564 829564 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814872 814872 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761460 761460 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745704 745704 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617258 617258 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657306 657306 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678589 678589 0 0.0
RAM 78668 78668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698433 698433 0 0.0
RAM 81300 81300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698433 698433 0 0.0
RAM 81300 81300 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655377 655377 0 0.0
RAM 73736 73736 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614933 614933 0 0.0
RAM 71628 71628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634569 634569 0 0.0
RAM 74180 74180 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634569 634569 0 0.0
RAM 74180 74180 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634213 634213 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653921 653921 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653921 653921 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609525 609525 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629385 629385 0 0.0
RAM 71396 71396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629385 629385 0 0.0
RAM 71396 71396 0 0.0
efr32 lock-app BRD4187C FLASH 925248 925248 0 0.0
RAM 159708 159708 0 0.0
BRD4338a FLASH 741432 741424 -8 -0.0
RAM 231008 231008 0 0.0
window-app BRD4187C FLASH 1018236 1018236 0 0.0
RAM 128052 128052 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1539960 1539960 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1550166 1550166 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781331 2781331 0 0.0
RAM 129520 129520 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6092456 6092456 0 0.0
RAM 524000 524000 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5423032 5423032 0 0.0
RAM 242416 242416 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751960 4751960 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13162732 13162732 0 0.0
RAM 584562 584562 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11721056 11721056 0 0.0
RAM 635488 635488 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11390811 11391975 1164 0.0
RAM 584954 585050 96 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4578356 4578356 0 0.0
RAM 205336 205336 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5693889 5693889 0 0.0
RAM 228488 228488 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801506 4801506 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430888 4430888 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569660 4569660 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3115949 3115949 0 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4319872 4319872 0 0.0
RAM 242896 242896 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6031989 6031989 0 0.0
RAM 596416 596416 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11367949 11367949 0 0.0
RAM 675936 675936 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915528 915528 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885992 885992 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848936 848936 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582296 0 0.0
RAM 70948 70948 0 0.0
mcxw71+release FLASH 596928 596928 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618932 618932 0 0.0
RAM 70412 70412 0 0.0
k32w1+release FLASH 683160 683160 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 705552 746712 41160 5.8
RAM 67324 67340 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647604 1647604 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553684 1553684 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1468004 1468004 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464980 1464980 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660600 660600 0 0.0
RAM 105396 105396 0 0.0
lock-app qpg6105+debug FLASH 618612 618612 0 0.0
RAM 99864 99864 0 0.0
stm32 light STM32WB5MM-DK FLASH 481936 481936 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 681164 681164 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620814 620814 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708794 708794 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625764 625764 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811772 811772 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1729708 1729708 0 0.0
RAM 90108 90108 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18329542 18329542 0 0.0
RAM 7970692 7970692 0 0.0

@mergify mergify bot merged commit 44db0f6 into project-chip:master Oct 22, 2024
67 checks passed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@tehampson @restyled-commits @yyzhong-g
Call DeviceReachableChanged when subscription fails (project-chip#36175)
ad09bbb 
* Call DeviceReachableChanged when subscription fails

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonhaengHeo joonhaengHeo joonhaengHeo approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @yufengwangca @joonhaengHeo @restyled-commits