DEMM, EVSEM, WHM, EEVSE, DEM, EWATERHTR zap XML out of date with 1.4 specs #36155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 7 of 43 files. File Information
|
2 tasks
|
PR #36155: Size comparison from 7d6373f to 3388bc3 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
…4 was backed out after it was felt to still be a draft). Taken in the DEM and WHM latest descriptions based on Alchemy autogen.
jamesharrow
changed the title
|
PR #36155: Size comparison from 7d6373f to d511b8e Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 19, 2024
…est_TC_EEVSEM_3_2.yaml, Test_TC_EEVSEM_3_3.yaml which were removed in test plan PR: CHIP-Specifications/chip-test-plans#4553
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36155: Size comparison from 7d6373f to ba14a2b Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… <domain> element text is empty
|
PR #36155: Size comparison from 7d6373f to 473a9b1 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 21, 2024
andy31415
added
the
skip-protocol-compatibility
jamesharrow
deleted the
Fix-EVSEM-DEMM-WHM-to-remove-OnMode-StartupMode-attributes
branch
Closed
1 task
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…specs (project-chip#36155) * Fixes project-chip#36059 * regen_all after change to mode cluster ZCL XML * Checking on EEVSE the cluster revision was wrong (looks like the rev 4 was backed out after it was felt to still be a draft). Taken in the DEM and WHM latest descriptions based on Alchemy autogen. * revert description in DEM which was truncated by Alchemy * regen_all * Removed src/app/tests/suites/certification/Test_TC_EEVSEM_3_1.yaml, Test_TC_EEVSEM_3_2.yaml, Test_TC_EEVSEM_3_3.yaml which were removed in test plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4553 * Reverted change to domain since ZAP does not show the clusters if the <domain> element text is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36059
Regenerated with Alchemy:
alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/Mode_EVSE.adocalchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec/ ./connectedhomeip_spec/src/app_clusters/Mode_WaterHeater.adocalchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/Mode_DeviceEnergyManagement.adocalchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/EnergyEVSE.adoc[NOTE Revision 3 is correct, but the XML was generated from interim spec, and then people felt that the Rev4 could be included into Rev 3 since it was still draft 1.4 - see https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/9878]
alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/EnergyEVSE.adocalchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/DeviceEnergyManagement.adocalchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip_spec ./connectedhomeip_spec/src/app_clusters/WaterHeaterManagement.adoccNote: I had to undo one of the changes made by Alchemy which was to change the
Since ZAP doesn't show the clusters if the domain doesn't include a text field. It's ok with
<configurator><domain name="Energy Management"/>just not inside the cluster element.Note: backwards compatibility check was failing because the EVSEM originally allowed DEPONOFF and OnMode and StartupMode in 1.3, but during 1.4 this cluster and WHM and DEMM all had these removed and made disallowed.