-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin-framework-tool] Add an option to use per-controller storage i… #36044
[darwin-framework-tool] Add an option to use per-controller storage i… #36044
Conversation
Review changes with SemanticDiff. |
3923420
to
25d3968
Compare
PR #36044: Size comparison from 3732a89 to 25d3968 Full report (3 builds for cc32xx, stm32)
|
25d3968
to
22a6b22
Compare
PR #36044: Size comparison from 8c0f11a to 22a6b22 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
22a6b22
to
48fe221
Compare
PR #36044: Size comparison from 7287041 to 48fe221 Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
48fe221
to
94d4755
Compare
PR #36044: Size comparison from 7287041 to 94d4755 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.h
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CertificateIssuer.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CertificateIssuer.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/CHIPCommandBridge.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
PR #36044: Size comparison from 7287041 to 45c013b Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
1b66871
to
cf8b2e6
Compare
PR #36044: Size comparison from 9524ac9 to cf8b2e6 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
cf8b2e6
to
1d0812b
Compare
PR #36044: Size comparison from 9524ac9 to 1d0812b Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
1d0812b
to
50be35e
Compare
50be35e
to
31d2025
Compare
examples/darwin-framework-tool/commands/common/CertificateIssuer.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/common/ControllerStorage.mm
Outdated
Show resolved
Hide resolved
31d2025
to
16b0c40
Compare
…nstead of a global shared storage
16b0c40
to
2f8e558
Compare
PR #36044: Size comparison from ac9537d to 2f8e558 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…nstead of a global shared storage (project-chip#36044)
…nstead of a global shared storage
Problem
Currently,
darwin-framework-tool
starts with shared storage for controllers. It would be useful to have a mechanism to start withper-controller
storage, as this triggers different code paths.This PR introduces this capability by adding a new
--commissioner-shared-storage
optional argument todarwin-framework-too
l. The default is set to true, preserving existing behavior.