[ICD] Improve ICDClientStorage #36036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
yunhanw-google
changed the title
-- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics
yunhanw-google
force-pushed
the
feature/icd_storage_test
branch
from
e832afb to
5d153dc
Compare
|
PR #36036: Size comparison from a76cc9b to 5d153dc Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: mkardous-silabs <[email protected]>
Co-authored-by: mkardous-silabs <[email protected]>
mkardous-silabs
approved these changes
Oct 11, 2024
|
PR #36036: Size comparison from a76cc9b to 685ba45 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36036: Size comparison from a76cc9b to 512f5c8 Increases above 0.2%:
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 11, 2024
|
PR #36036: Size comparison from a76cc9b to 8723c99 Increases above 0.2%:
Full report (3 builds for cc32xx, stm32)
|
yunhanw-google
force-pushed
the
feature/icd_storage_test
branch
from
8723c99 to
21356a2
Compare
|
PR #36036: Size comparison from 1988399 to 21356a2 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
force-pushed
the
feature/icd_storage_test
branch
from
21356a2 to
7334a09
Compare
|
PR #36036: Size comparison from f94fbfd to 7334a09 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
yunhanw-google
force-pushed
the
feature/icd_storage_test
branch
from
7334a09 to
51fa4b6
Compare
|
PR #36036: Size comparison from f94fbfd to eb3e1f6 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Oct 12, 2024
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
This was referenced Oct 12, 2024
yunhanw-google
added a commit
to yunhanw-google/connectedhomeip
that referenced
this pull request
Oct 12, 2024
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
dinabenamar
pushed a commit
to NXP/matter
that referenced
this pull request
Oct 24, 2024
…roject-chip#36055) * Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * Update DefaultICDClientStorage.cpp * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]> (cherry picked from commit 5335054)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
…6036) (project-chip#36055)" This reverts commit 7d9232e. Signed-off-by: Gatien Chapon <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we need update fabricList vector and persistent storage.
-- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error.
-- check error for writer.Finalize
-- return earlier when counter from load function is 0
-- Add multiple unit tests to cover the ordering combination around
DeleteAllEntries/StoreEntry/CheckInHandling for
multiple fabrics(fixes #30722)