python_testing: Add Checks for Command IDs #36018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds checks and unit tests for the command ID ranges defined in Table 79 of the spec. These checks will be used on the various Python tests, for example, TC_DeviceBasicComposition.py.
|
Review changes with SemanticDiff. Analyzed 3 of 3 files. Overall, the semantic diff is 5% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36018: Size comparison from 7a9bd66 to 7eecd8b Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Oct 10, 2024
|
PR #36018: Size comparison from 6880437 to 903b2d7 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This PR uses the newly added command id check. It updates the error msg to indicate if it's a "Test Vendor" id.
github-actions
bot
added
documentation
soares-sergio
force-pushed
the
add_command_id_checks
branch
from
18941dc to
4887b5d
Compare
|
PR #36018: Size comparison from 7287041 to 4887b5d Full report (20 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #36018: Size comparison from 7287041 to 0771274 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Oct 23, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* python_testing: Add Checks for Command IDs This PR adds checks and unit tests for the command ID ranges defined in Table 79 of the spec. These checks will be used on the various Python tests, for example, TC_DeviceBasicComposition.py. * Restyled by isort * python_testing: Update command id error msg This PR uses the newly added command id check. It updates the error msg to indicate if it's a "Test Vendor" id. * fix merge conflicts * Restyled by isort --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks and unit tests for the command ID ranges defined in Table 79 of the spec.
These checks will be used on the various Python tests, for example,
TC_DeviceBasicComposition.py.