-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of the Camera AV StreamManagement Cluster. #35841
Conversation
Review changes with SemanticDiff. Analyzed 12 of 82 files. Overall, the semantic diff is 1% smaller than the GitHub diff. File Information
|
dcacdcd
to
bd3d3e1
Compare
PR #35841: Size comparison from 86a5270 to bd3d3e1 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35841: Size comparison from 86a5270 to dbf76dc Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dbf76dc
to
e7cdfdb
Compare
PR #35841: Size comparison from 425b53c to e7cdfdb Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
e7cdfdb
to
5e4237f
Compare
PR #35841: Size comparison from b559f17 to 5e4237f Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
5e4237f
to
cbb5e8f
Compare
PR #35841: Size comparison from 43e447c to cbb5e8f Increases above 0.2%:
Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
cbb5e8f
to
49ec536
Compare
PR #35841: Size comparison from 9fc8386 to 49ec536 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please make sure the spec comments, both from this review and the previous one, are captured in the spec.
src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml
Outdated
Show resolved
Hide resolved
49ec536
to
fe33216
Compare
PR #35841: Size comparison from a629204 to fe33216 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
fe33216
to
9bcc3da
Compare
PR #35841: Size comparison from 1988399 to 9bcc3da Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Define StreamTypeEnum in global-enums.xml, moving from WebRTC Provider cluster and AV Stream Management. Spec in `cameras` branch. Draft PR: CHIP-Specifications/connectedhomeip-spec#10004
…ope block. This is to prevent duplicate declaration error when multiple variables of the same struct type are present.
9bcc3da
to
8638d24
Compare
PR #35841: Size comparison from bf37d4e to 8638d24 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…5841) * Definition of the Camera AV StreamManagement Cluster. Define StreamTypeEnum in global-enums.xml, moving from WebRTC Provider cluster and AV Stream Management. Spec in `cameras` branch. Draft PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10004 * Keep the jclass and its corresponding constructor jmethod inside a scope block. This is to prevent duplicate declaration error when multiple variables of the same struct type are present. * Auto-generated files from zap-regen for Camera AV Stream Management.
XML, json and ZAP generated files.
Spec in
cameras
branch.Draft PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10004