Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing support for returning credential data in GetCredentialStatusResponse. #35732

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add missing support for returning credential data in GetCredentialStatusResponse. #35732

merged 2 commits into from
Sep 24, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Sep 23, 2024 •
edited
Loading

The first changeset here is manually created. The second is just codegen.

skip-protocol-compatibility, since this is a compatible change: it adds an optional field to a command.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 23, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 3 of 21 files.

File Information
Filename Status
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRCommandPayloadsObjc.mm Unsupported file format
❔ src/darwin/Framework/CHIP/templates/availability.yaml Unsupported file format
✔️ src/controller/python/chip/clusters/Objects.py Analyzed
❔ src/controller/java/generated/java/matter/controller/cluster/clusters/DoorLockCluster.kt Unsupported file format
✔️ src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java Analyzed
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java Analyzed
❔ src/controller/data_model/controller-clusters.matter Unsupported file format
❔ src/app/zap-templates/zcl/data-model/chip/door-lock-cluster.xml Unsupported file format
❔ src/app/clusters/door-lock-server/door-lock-server.cpp Unsupported file format
❔ examples/virtual-device-app/virtual-device-common/virtual-device-app.matter Unsupported file format
❔ examples/placeholder/linux/apps/app2/config.matter Unsupported file format
❔ examples/placeholder/linux/apps/app1/config.matter Unsupported file format
❔ examples/lock-app/qpg/zap/lock.matter Unsupported file format
❔ examples/lock-app/nxp/zap/lock-app.matter Unsupported file format
❔ examples/lock-app/lock-common/lock-app.matter Unsupported file format
❔ examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter Unsupported file format
❔ examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter Unsupported file format

@bzbarsky-apple bzbarsky-apple added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Sep 23, 2024
@bzbarsky-apple bzbarsky-apple force-pushed the aliro-credential-data-in-status branch from 24bf3d6 to 8624c36 Compare September 23, 2024 19:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

PR #35732: Size comparison from 8750c55 to 8624c36

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8750c55 8624c36 change % change
bl602 lighting-app bl602 FLASH 1280232 1280232 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1294354 1294354 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1320438 1320438 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 944328 944328 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946728 946728 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039892 1039892 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646534 646534 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894604 894604 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960988 960988 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963610 963610 0 0.0
RAM 16964 16964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829380 829380 0 0.0
RAM 123300 123300 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814352 814416 64 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760428 760428 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 744664 744664 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616154 616154 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656050 656210 160 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677765 677765 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697617 697617 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697617 697617 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654553 654553 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613837 613837 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633473 633473 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633473 633473 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633061 633125 64 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652769 652841 72 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652769 652841 72 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608469 608469 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628329 628329 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628329 628329 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933324 933324 0 0.0
RAM 135084 135084 0 0.0
lock-app BRD2605a FLASH 740728 740816 88 0.0
RAM 231220 231220 0 0.0
BRD4338a FLASH 741376 741480 104 0.0
RAM 231252 231252 0 0.0
window-app BRD4187C FLASH 1016376 1016368 -8 -0.0
RAM 127004 127004 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1537572 1537572 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1547998 1548006 8 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2764621 2764621 0 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6068110 6068110 0 0.0
RAM 507360 507392 32 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5401442 5401440 -2 -0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4735062 4735062 0 0.0
RAM 218304 218304 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12546538 12546926 388 0.0
RAM 555090 555122 32 0.0
chip-tool-ipv6only arm64 unknown 20456 20456 0 0.0
FLASH 11204432 11204704 272 0.0
RAM 605336 605368 32 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 10908791 10908791 0 0.0
RAM 554234 554266 32 0.0
fabric-bridge-app debug unknown 4640 4640 0 0.0
FLASH 4561674 4561674 0 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5676001 5676001 0 0.0
RAM 228552 228552 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4784266 4785134 868 0.0
RAM 204376 204376 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4417418 4417418 0 0.0
RAM 198112 198112 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4556166 4556166 0 0.0
RAM 202680 202680 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3095373 3095373 0 0.0
RAM 159184 159184 0 0.0
thermostat-no-ble arm64 unknown 9432 9432 0 0.0
FLASH 4306728 4306728 0 0.0
RAM 242808 242808 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6013397 6013397 0 0.0
RAM 580896 580928 32 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10739837 10740189 352 0.0
RAM 642976 643008 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913444 913444 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885016 885016 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846956 846956 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581760 581760 0 0.0
RAM 70776 70776 0 0.0
k32w1+release FLASH 594376 594376 0 0.0
RAM 62944 62944 0 0.0
mcxw71+release FLASH 594128 594128 0 0.0
RAM 62944 62944 0 0.0
light k32w0+release FLASH 617812 617812 0 0.0
RAM 70248 70248 0 0.0
k32w1+release FLASH 681008 681008 0 0.0
RAM 48584 48584 0 0.0
mcxw71+release FLASH 681024 681024 0 0.0
RAM 48584 48584 0 0.0
lock k32w1+release FLASH 702984 702984 0 0.0
RAM 67084 67084 0 0.0
mcxw71+release FLASH 703008 703008 0 0.0
RAM 67084 67084 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645332 1645332 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551332 1551332 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467148 1467148 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463764 1463876 112 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 659520 659520 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 617420 617476 56 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481072 481072 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620120 620120 0 0.0
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687354 687354 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780288 780288 0 0.0
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 681124 681124 0 0.0
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 619882 619882 0 0.0
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707824 707824 0 0.0
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624846 624846 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810498 810498 0 0.0
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655670 655728 58 0.0
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 697100 697100 0 0.0
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633506 633506 0 0.0
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610696 610696 0 0.0
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467336 467336 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 626848 626848 0 0.0
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652832 652832 0 0.0
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637426 637426 0 0.0
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523612 523612 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4876 4876 0 0.0
FLASH 1722360 1722360 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10316 10316 0 0.0
FLASH 17350538 17351682 1144 0.0
RAM 7559272 7559848 576 0.0

@mergify mergify bot merged commit b6a1304 into project-chip:master Sep 24, 2024
72 checks passed
@bzbarsky-apple bzbarsky-apple deleted the aliro-credential-data-in-status branch September 24, 2024 17:36
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Add missing support for returning credential data in GetCredentialSt…
4b2673e 
…atusResponse. (project-chip#35732)

* Add missing support for returning credential data in GetCredentialStatusResponse.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiel-apple kiel-apple kiel-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @kiel-apple