Chime Cluster Definition and server code #35729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 3 of 10 files.
|
|
|
|
Will add generated code in second commit as soon as I get some feedback on this. |
|
PR #35729: Size comparison from 8750c55 to 4d9380a Full report (33 builds for cc13x4_26x4, cyw30739, efr32, nxp, psoc6)
|
There was a problem hiding this comment.
Ideally, the implementation would be a separate PR from adding the XML.
| return aEncoder.Encode(mDelegate.GetInstalledChimeSounds()); | ||
|
|
||
| case ActiveChimeSoundId::Id: | ||
| return aEncoder.Encode(mDelegate.GetActiveChimeSoundId()); |
There was a problem hiding this comment.
It would be better if the simple things that can be stored in the cluster were stored there, so we can mark things dirty properly on changes.
| return CHIP_NO_ERROR; | ||
| } | ||
|
|
||
| CHIP_ERROR ChimeServer::SetEnabled(bool enabled) |
There was a problem hiding this comment.
OK, but the write path is not calling this?
There was a problem hiding this comment.
Thanks, that's an error
| virtual ~ChimeDelegate() = default; | ||
|
|
||
| // Get Attribute Methods | ||
| virtual DataModel::List<const Chime::Structs::ChimeSoundStruct::Type>& GetInstalledChimeSounds() = 0; |
There was a problem hiding this comment.
What's the lifetime of the buffer backing that list? How does the delegate know to not deallocate it?
Also, it it intentional that this implementation does not allow chunking the list?
| <item name="Name" type="char_string" max="48"/> | ||
| </struct> | ||
|
|
||
| <cluster apiMaturity="provisional"> |
There was a problem hiding this comment.
Where is the spec for this? I don't see it in the Matter appclusters spec on "master"....
It's impossible to review this XML without the spec.
There was a problem hiding this comment.
it's in the Cameras branch
|
FYI chime cluster PR went in @ #35806 Apologies did not realize you were working on this as well or would've reached out - started a chat on slack so we can coordinate |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chime cluster definition and server code